tkhurana commented on code in PR #2064:
URL: https://github.com/apache/phoenix/pull/2064#discussion_r1931159423
##########
phoenix-core-client/src/main/java/org/apache/phoenix/execute/MutationState.java:
##########
@@ -1530,7 +1531,7 @@ public List<Mutation> getMutationList() {
// REPLAY_ONLY_INDEX_WRITES for first batch
// only in case of 1121 SQLException
itrListMutation.remove();
-
+ mutationBatchSuccessCounter++;
Review Comment:
I feel most of the value is in knowing how many batches we created per
commit. That is where we can tune the various parameters to improve
performance. If the commit succeeds the `mutationBatchSuccessCounter` will be
the same as size of the list. If the commit fails, they might be different but
that doesn't seem very interesting from metrics perspective. There is also a
`batchCount` variable which seems to be tracking the same thing but
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
