chaijunjie0101 commented on code in PR #2079:
URL: https://github.com/apache/phoenix/pull/2079#discussion_r1961553326
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java:
##########
@@ -2614,6 +2614,15 @@ public QueryPlan getQueryPlan() {
@Override
public ResultSet getResultSet() throws SQLException {
ResultSet rs = getLastResultSet();
+ if (!isClosed && rs == null && lastQueryPlan != null) {
Review Comment:
> This feels like this a band-aid to cover for an error in the resultset
logic.
>
> Can we fix the logic instad so that this is hacky solution is not needed ?
yeah...But if we set the resultSet on this statement...may break the old
logic...not sure why set ResultSet in the QueryPlan's context? it is differnt
with JDBC statement logic...we need be careful to change some old logic even it
is wrong...need keep maintain compatibility.
I will check again if we could fix the wrong resultset logic, or if you want
to fix it, you also could do it~
Thanks for reviewing~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
