stoty commented on code in PR #2079:
URL: https://github.com/apache/phoenix/pull/2079#discussion_r1997959922
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java:
##########
@@ -2614,6 +2614,15 @@ public QueryPlan getQueryPlan() {
@Override
public ResultSet getResultSet() throws SQLException {
ResultSet rs = getLastResultSet();
+ if (!isClosed && rs == null && lastQueryPlan != null) {
Review Comment:
I don't get it.
newResultSet() calls PhoenixResultSet constructor, which then calls
statement.setLastResultSet() on line 178.
Why would calling setLastResultSet() again on the same Statement object make
a difference ?
Are you sure your tests are testing for your original issue ?
Maybe I'm missing something, in that clase can you point out where my
assessment above is wrong ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
