ritegarg commented on code in PR #2075: URL: https://github.com/apache/phoenix/pull/2075#discussion_r1996326268
########## phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixHACache.java: ########## @@ -0,0 +1,196 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.phoenix.jdbc; + + +import org.apache.curator.framework.CuratorFramework; +import org.apache.curator.framework.api.CuratorWatcher; +import org.apache.curator.framework.api.GetDataBuilder; +import org.apache.curator.framework.recipes.cache.NodeCache; +import org.apache.curator.utils.ZKPaths; +import org.apache.hadoop.conf.Configuration; +import org.apache.phoenix.thirdparty.com.google.common.annotations.VisibleForTesting; +import org.apache.phoenix.thirdparty.com.google.common.cache.Cache; +import org.apache.phoenix.thirdparty.com.google.common.cache.CacheBuilder; +import org.apache.phoenix.thirdparty.com.google.common.cache.RemovalCause; +import org.apache.phoenix.thirdparty.com.google.common.cache.RemovalListener; +import org.apache.zookeeper.WatchedEvent; +import org.apache.zookeeper.Watcher; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + +import java.io.Closeable; +import java.io.IOException; +import java.time.Duration; +import java.util.ArrayList; +import java.util.List; +import java.util.Set; +import java.util.concurrent.ConcurrentHashMap; + +import static org.apache.phoenix.jdbc.PhoenixHAAdmin.toPath; +import static org.apache.phoenix.query.QueryServices.HA_CACHE_TTL_MS; +import static org.apache.phoenix.query.QueryServicesOptions.DEFAULT_HA_CACHE_TTL_IN_MS; + +/** + * Write-through cache for PhoenixHA. + * Uses {@link NodeCache} from {@link org.apache.curator.framework.CuratorFramework}. + */ +public class PhoenixHACache implements Closeable { + + private static PhoenixHACache cacheInstance; + private final PhoenixHAAdmin phoenixHaAdmin; + // Thread-Safe as per https://www.javadoc.io/doc/com.google.guava/guava/20.0/com/google/common/cache/Cache.html + private Cache<String, ClusterRoleRecord> haGroupClusterRoleRecordMap = null; + private static final Logger LOGGER = LoggerFactory.getLogger(PhoenixHACache.class); + private final Set<String> activeToStandbyHAGroups = ConcurrentHashMap.newKeySet(); + + /** + * Creates/gets an instance of PhoenixHACache. + * + * @param conf configuration + * @return cache + */ + public static PhoenixHACache getInstance(Configuration conf) throws Exception { + PhoenixHACache result = cacheInstance; + if (result == null) { + synchronized (PhoenixHACache.class) { + result = cacheInstance; + if (result == null) { + cacheInstance = result = new PhoenixHACache(conf); + } + } + } + return result; + } + + + private PhoenixHACache(final Configuration conf) throws Exception { + this.phoenixHaAdmin = new PhoenixHAAdmin(conf); + this.haGroupClusterRoleRecordMap = CacheBuilder.newBuilder() + .expireAfterWrite(Duration.ofMillis(conf.getLong(HA_CACHE_TTL_MS, DEFAULT_HA_CACHE_TTL_IN_MS))) + .removalListener((RemovalListener<String, ClusterRoleRecord>) notification -> { + String key = notification.getKey(); + LOGGER.info("PhoenixHACache HAGroupCRRMap Received event for key {} because of {}", key, notification.getCause().name()); + if (notification.getCause() == RemovalCause.EXPIRED) { + ClusterRoleRecord clusterRoleRecord = notification.getValue(); + if (clusterRoleRecord != null) { + try { + clusterRoleRecord = getCurrentValue(clusterRoleRecord); + haGroupClusterRoleRecordMap.put(clusterRoleRecord.getHaGroupName(), clusterRoleRecord); + checkAndUpdateMutationBlockingHAGroups(clusterRoleRecord); + } catch (Exception e) { + LOGGER.error("Failed to rebuild NodeCache for haGroupName " + key, e); + throw new RuntimeException(e); + } + } + } + }) + .build(); + + // Create a watcher for Parent ZNode Path + CuratorWatcher parentWatcher = new CuratorWatcher() { + @Override + public void process(WatchedEvent event) throws Exception { + LOGGER.info("PhoenixHACache ParentWatcher Received event for key {} because of {}", event.getPath(), event.getType()); + if (event.getType() == Watcher.Event.EventType.NodeChildrenChanged) { + List<String> haGroupNames = phoenixHaAdmin.getCurator().getChildren().usingWatcher(this).forPath(ZKPaths.PATH_SEPARATOR); + List<String> existingKeys = new ArrayList<>(haGroupClusterRoleRecordMap.asMap().keySet()); + if (haGroupNames != null && !haGroupNames.equals(existingKeys)) { + rebuild(null); Review Comment: Now we are calling rebuild only externally using the API -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
