ujjawal4046 commented on code in PR #2075:
URL: https://github.com/apache/phoenix/pull/2075#discussion_r2012407724
##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##########
@@ -1055,4 +1057,20 @@ public void
preClose(ObserverContext<RegionCoprocessorEnvironment> c, boolean ab
protected boolean isRegionObserverFor(Scan scan) {
return
scan.getAttribute(BaseScannerRegionObserverConstants.UNGROUPED_AGG) != null;
}
+
+ @Override
+ public void preBatchMutate(ObserverContext<RegionCoprocessorEnvironment> c,
Review Comment:
@ritegarg @jpisaac Do we need to change the coprocessor priority for this
observer ? The call order for coprocs is based on the priority.
I see that all phoenix coprocs use
QueryServicesOptions.DEFAULT_COPROCESSOR_PRIORITY. E.g. if both
UngroupedAggregateRegionObserver and IndexRegionObserver both define the
preBatchMutate hook, what would be the call order ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
