palashc commented on code in PR #2075:
URL: https://github.com/apache/phoenix/pull/2075#discussion_r2012944150


##########
phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java:
##########
@@ -1055,4 +1057,20 @@ public void 
preClose(ObserverContext<RegionCoprocessorEnvironment> c, boolean ab
     protected boolean isRegionObserverFor(Scan scan) {
         return 
scan.getAttribute(BaseScannerRegionObserverConstants.UNGROUPED_AGG) != null;
     }
+
+    @Override
+    public void preBatchMutate(ObserverContext<RegionCoprocessorEnvironment> c,

Review Comment:
   Looks like this is the coproc chain:
   `
   coprocessor$1 => 
'|org.apache.phoenix.coprocessor.ScanRegionObserver|805306366|', coprocessor$2 
=> 
'|org.apache.phoenix.coprocessor.UngroupedAggregateRegionObserver|805306366|', 
coprocessor$3 => 
'|org.apache.phoenix.coprocessor.GroupedAggregateRegionObserver|805306366|', 
coprocessor$4 => 
'|org.apache.phoenix.coprocessor.ServerCachingEndpointImpl|805306366|', 
coprocessor$5 => 
'|org.apache.phoenix.hbase.index.IndexRegionObserver|805306366|index.builder=org.apache.phoenix.index.PhoenixIndexBuilder,org.apache.hadoop.hbase.index.codec.class=org.apache.phoenix.index.PhoenixIndexCodec',
 coprocessor$6 => 
'|org.apache.phoenix.coprocessor.PhoenixTTLRegionObserver|805306364|'
   `
   
   Just to be sure, maybe we should change the priority? 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to