ritegarg commented on code in PR #2138:
URL: https://github.com/apache/phoenix/pull/2138#discussion_r2082551466


##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -451,9 +463,10 @@ private PMetaData newEmptyMetaData() {
     /**
      * Construct a ConnectionQueryServicesImpl that represents a connection to 
an HBase
      * cluster.
-     * @param services base services from where we derive our default 
configuration
+     *
+     * @param services       base services from where we derive our default 
configuration
      * @param connectionInfo to provide connection information
-     * @param info hbase configuration properties
+     * @param info           hbase configuration properties
      */
     public ConnectionQueryServicesImpl(QueryServices services, ConnectionInfo 
connectionInfo, Properties info) {

Review Comment:
   shutdown threadpool in close.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to