tkhurana commented on code in PR #2138:
URL: https://github.com/apache/phoenix/pull/2138#discussion_r2083624886
##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -480,6 +493,24 @@ public ConnectionQueryServicesImpl(QueryServices services,
ConnectionInfo connec
// on the server side during testing.
this.config =
HBaseFactoryProvider.getConfigurationFactory().getConfiguration(config);
+ if (this.config.getBoolean(CQSI_THREAD_POOL_ENABLED,
DEFAULT_CQSI_THREAD_POOL_ENABLED)) {
Review Comment:
I think it is better to rename `this.config` to something else like
`finalConfig` to avoid any confusion with the other local config object in this
function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
