virajjasani commented on code in PR #2286:
URL: https://github.com/apache/phoenix/pull/2286#discussion_r2345633573
##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java:
##########
@@ -1748,7 +1748,9 @@ private void checkAndRetry(RetriableOperation op) throws
InterruptedException, T
}
}
numTries++;
- Thread.sleep(sleepInterval);
+ if (!success) {
+ Thread.sleep(sleepInterval);
+ }
} while (numTries < maxRetries && !success);
Review Comment:
I kept `numTries = 0` so let's say maxRetries = 1, we will execute this only
once and error out. Shall we treat maxRetries as total num of attempts or total
num of retries?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
