virajjasani commented on code in PR #2286:
URL: https://github.com/apache/phoenix/pull/2286#discussion_r2346841521
##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java:
##########
@@ -314,8 +314,8 @@ public class QueryServicesOptions {
public static final boolean DEFAULT_EXPLAIN_CHUNK_COUNT = true;
public static final boolean DEFAULT_EXPLAIN_ROW_COUNT = true;
public static final boolean DEFAULT_ALLOW_ONLINE_TABLE_SCHEMA_UPDATE = true;
- public static final int DEFAULT_RETRIES_FOR_SCHEMA_UPDATE_CHECK = 10;
- public static final long DEFAULT_DELAY_FOR_SCHEMA_UPDATE_CHECK = 5 * 1000;
// 5 seconds.
+ public static final int DEFAULT_RETRIES_FOR_SCHEMA_UPDATE_CHECK = 50;
+ public static final long DEFAULT_DELAY_FOR_SCHEMA_UPDATE_CHECK = 1000; // 1
second.
Review Comment:
@d-c-manning given that DDL operations in normal cases take 500-800ms to
complete, it is likely that first time `op.checkForCompletion()` might return
false and we might have to sleep temporarily only once but sleeping for 5s
seems quite time consuming, so maybe 1s is not bad I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
