Copilot commented on code in PR #2288:
URL: https://github.com/apache/phoenix/pull/2288#discussion_r2411941990
##########
phoenix-core/src/it/java/org/apache/phoenix/jdbc/HighAvailabilityTestingUtility.java:
##########
@@ -660,6 +956,9 @@ private static void setUpDefaultHBaseConfig(Configuration
conf) {
conf.setInt(PHOENIX_HA_ZK_RETRY_BASE_SLEEP_MS_KEY, 100);
conf.setInt(PHOENIX_HA_ZK_RETRY_MAX_KEY, 2);
conf.setInt(PHOENIX_HA_ZK_RETRY_MAX_SLEEP_MS_KEY, 1000);
+ //This is Needed to get CRR when one cluster is down as RPC
timeout is 2 sec and server
+ //will wait below time to try to get Peer record info from dead
cluster
Review Comment:
Several inline comments have grammatical issues and inconsistent
capitalization. Consider improving the clarity and consistency of these
comments.
```suggestion
// This is needed to get CRR when one cluster is down, as the
RPC timeout is 2 seconds and the server
// will wait for the specified time to try to retrieve peer
record information from the dead cluster.
```
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixHAAdmin.java:
##########
@@ -151,6 +151,12 @@ public static String getLocalZkUrl(Configuration conf) {
return String.format("%s:%d:%s", localZkQuorum, port, localZkRoot);
}
+ public static String getLocalMasterUrl(Configuration conf) {
+ String local = conf.get(HConstants.MASTER_ADDRS_KEY).replaceAll(":",
"\\\\:");
+ LOG.info("LOCAL MASTERRRRRRR {}", local);
Review Comment:
Debug log message contains informal text 'LOCAL MASTERRRRRRR' which should
be cleaned up for production code. Consider using a more professional log
message or removing if no longer needed for debugging.
```suggestion
LOG.info("Local master URL: {}", local);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
