apurtell opened a new pull request, #2497: URL: https://github.com/apache/phoenix/pull/2497
Use the new infrastructure for parsing and validating `EXPLAIN` plan output from PHOENIX-7879 to power assertions on query plans in ~70 various IT and UT tests. Expand `ExplainPlanAttributes` and implement `ExplainPlanTestUtils` so tests can use a fluent assertion API (`assertPlan`) rather than exact matching of text strings. There are no changes made yet to the actual format of `EXPLAIN` text output as it gets presented to the user. We also are not expanding or reducing existing test coverage. However After expanding ExplainPlanAttributes with additional details/fields, reorganize its attribute display order for better logical grouping. This only impacts future `EXPLAIN JSON` functionality that doesn't even exist yet. Some exact matching of text remains so we don't lose coverage that used to exist in `QueryPlanTest`. Further test refactoring is likely down the road to fully rely on `assertPlan`, but that won't happen until the new `EXPLAIN` logic is implemented and output grammar validation is built. Generated-by: Claude Opus 4.8[1m] <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
