apurtell opened a new pull request, #2503: URL: https://github.com/apache/phoenix/pull/2503
Refactor every IT and UT that asserted on `EXPLAIN` text to use the new fluent `ExplainPlanTestUtil.assertPlan` API over `ExplainPlanAttributes`. Emitted text and JSON shape are unchanged. Coverage is preserved. `ExplainPlanAttributes` is regrouped and gains an ordered `clientSteps` list plus `lhsJoinQueryExplainPlan`, `subPlans`, `dynamicServerFilter`, `afterJoinFilter`, `joinScannerLimit`, `sortMergeSkipMerge`, `serverGroupByLimit`, `regionLocationsTotalSize`, and `numRegionLocationLookups`. `SortMergeJoinPlan.getExplainPlan()` is reshaped into a synthetic root carrying the join operator with separate `lhs` and `rhs` children. `HashJoinPlan.getExplainPlan()` now populates attributes for sub-plans, post join filters, and scanner limits. `ClientAggregatePlan` and `ClientScanPlan` plus the merge-sort, ordered, limiting, and offset iterators add `clientSteps` to plan explanation. `ExplainPlanTestUtil` adds `lhs()` and `rhs()` navigation and various new assertions such as `clientStepCount`, `clientStep(i)`, `clientSteps(...)`, and others. `ExplainJsonNormalizer` recurses into `lhs`, `rhs`, and `subPlans`. Co-authored-by: Claude Opus 4.8[1m] <[email protected]> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
