Copilot commented on code in PR #2518:
URL: https://github.com/apache/phoenix/pull/2518#discussion_r3406547972
##########
phoenix-core/src/test/java/org/apache/phoenix/jdbc/HAGroupStoreRecordTest.java:
##########
@@ -257,6 +257,12 @@ public void testHAGroupStateGetClusterRole() {
HAGroupStoreRecord.HAGroupState.STANDBY_TO_ACTIVE.getClusterRole());
assertEquals(ClusterRoleRecord.ClusterRole.UNKNOWN,
HAGroupStoreRecord.HAGroupState.UNKNOWN.getClusterRole());
+
+ // ANISTS is non-blocking (maps to ACTIVE); only AISTS blocks mutations.
Review Comment:
The test comment uses unexplained acronyms ("ANISTS"/"AISTS") that don’t
appear elsewhere in the codebase, which makes the intent harder to understand
when reading the test in isolation. Prefer spelling out the concrete
HAGroupState names being asserted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
