apurtell commented on code in PR #2518:
URL: https://github.com/apache/phoenix/pull/2518#discussion_r3406669820
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAGroupStoreRecord.java:
##########
@@ -114,7 +114,7 @@ public ClusterRoleRecord.ClusterRole getClusterRole() {
ACTIVE_IN_SYNC_TO_STANDBY.allowedTransitions =
ImmutableSet.of(ABORT_TO_ACTIVE_IN_SYNC, STANDBY);
STANDBY_TO_ACTIVE.allowedTransitions = ImmutableSet.of(ABORT_TO_STANDBY,
ACTIVE_IN_SYNC);
- DEGRADED_STANDBY.allowedTransitions = ImmutableSet.of(STANDBY);
+ DEGRADED_STANDBY.allowedTransitions = ImmutableSet.of(STANDBY,
STANDBY_TO_ACTIVE);
Review Comment:
Looks good. Fixes a DS side deadlock at peer AISTS.
##########
phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HAGroupStoreRecord.java:
##########
@@ -76,11 +76,11 @@ public ClusterRoleRecord.ClusterRole getClusterRole() {
case ABORT_TO_ACTIVE_NOT_IN_SYNC:
case ACTIVE_IN_SYNC:
case ACTIVE_NOT_IN_SYNC:
+ case ACTIVE_NOT_IN_SYNC_TO_STANDBY:
Review Comment:
Looks good. Reduces unavailability during failover. The safety argument
shifts from single writer mapping directly to role to something a bit more
complicated where the transition tables do not allow the peer to promote so we
still have only a single writer in all states.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
