virajjasani commented on code in PR #14:
URL: https://github.com/apache/phoenix-adapters/pull/14#discussion_r3648919113
##########
phoenix-ddb-rest/src/test/java/org/apache/phoenix/ddb/ConnectionConfigIT.java:
##########
@@ -62,6 +62,8 @@ public static void initialize() throws Exception {
utility.startMiniCluster();
String zkQuorum = "127.0.0.1:" +
utility.getZkCluster().getClientPort();
url = PhoenixRuntime.JDBC_PROTOCOL +
PhoenixRuntime.JDBC_PROTOCOL_SEPARATOR + zkQuorum;
+ TestUtils.awaitPhoenixReady(url);
+
Review Comment:
We have 2 options:
1. remove `awaitPhoenixReady()` from this test
2. remove this test entirely
I prefer option 1, which means this single IT test will not be protected by
`awaitPhoenixReady()` and can lead to flaky test failure, which is okay.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
