virajjasani commented on code in PR #14:
URL: https://github.com/apache/phoenix-adapters/pull/14#discussion_r3670878872
##########
phoenix-ddb-rest/src/test/java/org/apache/phoenix/ddb/ConnectionConfigIT.java:
##########
@@ -60,8 +60,9 @@ public static void initialize() throws Exception {
utility = new HBaseTestingUtility(conf);
setUpConfigForMiniCluster(conf);
utility.startMiniCluster();
- String zkQuorum = "127.0.0.1:" +
utility.getZkCluster().getClientPort();
+ String zkQuorum = "localhost:" +
utility.getZkCluster().getClientPort();
Review Comment:
Here we should let it be 127.0.0.1 otherwise we have test failure in the
latest build?
##########
phoenix-ddb-rest/src/test/java/org/apache/phoenix/ddb/ConnectionConfigIT.java:
##########
@@ -60,8 +60,9 @@ public static void initialize() throws Exception {
utility = new HBaseTestingUtility(conf);
setUpConfigForMiniCluster(conf);
utility.startMiniCluster();
- String zkQuorum = "127.0.0.1:" +
utility.getZkCluster().getClientPort();
+ String zkQuorum = "localhost:" +
utility.getZkCluster().getClientPort();
Review Comment:
Basically no change needed in this IT test :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
