sanjeet006py commented on code in PR #2574:
URL: https://github.com/apache/phoenix/pull/2574#discussion_r3720151184
##########
phoenix-core-client/src/main/java/org/apache/phoenix/coprocessorclient/BaseScannerRegionObserverConstants.java:
##########
@@ -131,6 +131,12 @@ public static long getMaxLookbackInMillis(Configuration
conf) {
public static final String SKIP_REGION_BOUNDARY_CHECK =
"_SKIP_REGION_BOUNDARY_CHECK";
public static final String TX_SCN = "_TxScn";
public static final String TTL = "_TTL";
+ // Literal TTL threaded per-mutation for the server-side internal
current-row scan
Review Comment:
I intentionally used a new mutation attribute for literal TTL as currently
in `updateMutationsForConditionalTTL` there is a blind cast of TTL expression
to Conditional TTL expression and moreover, in IndexRegionObserver there is
implicit assumption that if `_TTL` attribute is set on a mutation then its
conditional TTL. If client changes in this PR gets deployed earlier then server
changes, then that can break mutation path by throwing ClassCastException.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
