tkhurana commented on code in PR #2574:
URL: https://github.com/apache/phoenix/pull/2574#discussion_r3721859683
##########
phoenix-core-client/src/main/java/org/apache/phoenix/coprocessorclient/BaseScannerRegionObserverConstants.java:
##########
@@ -131,6 +131,12 @@ public static long getMaxLookbackInMillis(Configuration
conf) {
public static final String SKIP_REGION_BOUNDARY_CHECK =
"_SKIP_REGION_BOUNDARY_CHECK";
public static final String TX_SCN = "_TxScn";
public static final String TTL = "_TTL";
+ // Literal TTL threaded per-mutation for the server-side internal
current-row scan
Review Comment:
The current check was done because it was a cheap way to do it but the
server can deserialize the ttl expression and can easily determine if the
expression is a literal ttl or conditional ttl. If the server is upgraded first
which is typically the case it will remain backward compatible to any client
using conditional ttl. I am not sure if we really need to worry about the case
of the client getting deployed before server. That can cause all sorts of other
issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
