lokiore commented on PR #2611: URL: https://github.com/apache/phoenix/pull/2611#issuecomment-5672468517
@tkhurana added coverage in `BaseImmutableIndexIT` (2ff28fdb17). It runs under both `ServerSideImmutableIndexIT` (flag on) and `ClientSideImmutableIndexIT` (flag off) and is parameterized over `columnEncoded`, so each test executes against both `ONE_CELL_PER_COLUMN` and `SINGLE_CELL_ARRAY_WITH_OFFSETS` — the matrix combination the `GlobalIndexCheckerIT` tests skipped. - (A) SINGLE_CELL partial upsert: `testPartialUpsertForImmutableCoveredIndex` and `testPartialUpsertForImmutableUncoveredIndex` run under `columnEncoded=true` (-> `SINGLE_CELL_ARRAY_WITH_OFFSETS`) with a matching-scheme index — full-then-partial upsert asserting index/data agreement (and, for the uncovered case, a COUNT over the index, which does not self-heal). The single-cell `getAllColumnsForDataTable`/`addColumnRefForScan` fast path is now exercised on both maintenance sides. - (B) Index-WHERE: `testPartialUpsertForImmutablePartialIndex` creates `CREATE INDEX … WHERE …` on an immutable table and omits the WHERE column. - (C) Delete over immutable `ROW_TIMESTAMP` + index: `testDeleteFromImmutableRowTimestampTableWithIndex` exercises the exact `DeleteCompiler` signature-change branch, asserting the surviving `ROW_TIMESTAMP` rows remain reachable in their bands. - (D) Multiple global indexes: `testPartialUpsertForImmutableMultipleIndexes` covers the cross-maintainer column union in `isPartialGlobalIndexMutation`. Also added `testPartialUpsertForImmutableMultipleColumnFamilies` and `testPartialUpsertForImmutableMixedStorageSchemeIndexes` (a matching + a mismatched-scheme index on the same table, with a non-self-healing COUNT served from the mismatched-scheme index). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
