lokiore commented on code in PR #2611:
URL: https://github.com/apache/phoenix/pull/2611#discussion_r4018893075
##########
phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java:
##########
@@ -433,7 +433,7 @@ public class QueryServicesOptions {
public static final long DEFAULT_GLOBAL_INDEX_ROW_AGE_THRESHOLD_TO_DELETE_MS
=
7 * 24 * 60 * 60 * 1000; /* 7 days */
public static final boolean DEFAULT_INDEX_REGION_OBSERVER_ENABLED = true;
- public static final boolean DEFAULT_SERVER_SIDE_IMMUTABLE_INDEXES_ENABLED =
false;
+ public static final boolean DEFAULT_SERVER_SIDE_IMMUTABLE_INDEXES_ENABLED =
true;
Review Comment:
most of the tests added are in BaseImmutableIndexIT which is being extended
by ServerSideImmutableIndexIT and ClientSideImmutableIndexIT (irrespective of
default) we are testing both for these ITs atleast. Other general index ITs
work on default value.
I'll update the PR to make it false by default and update the PR and JIRA
accordingly. Thanks for approval
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
