dimas-b commented on code in PR #422:
URL: https://github.com/apache/polaris/pull/422#discussion_r1842702661
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -75,17 +76,20 @@ private void initializeForRealm(RealmContext realmContext) {
}
@Override
- public synchronized Map<String,
PolarisMetaStoreManager.PrincipalSecretsResult> bootstrapRealms(
- List<String> realms) {
+ public Map<String, PolarisMetaStoreManager.PrincipalSecretsResult>
bootstrapRealms(
+ List<String> realms, Function<String, PrincipalSecretsGenerator>
rootSecretsPerRealm) {
Review Comment:
I'd probably have to add realm to `PolarisCallContext`.
From my POV, I wanted to avoid exposing realm to lower-level code for better
abstraction.
In practice only one realm is normally bootstrapped at a time, so we can
probably drop the realm parameter completely and use env. vars. like
`POLARIS_BOOTSTRAP_ROOT_CLIENT_ID`. WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
