dimas-b commented on code in PR #422:
URL: https://github.com/apache/polaris/pull/422#discussion_r1847647972


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -75,17 +76,20 @@ private void initializeForRealm(RealmContext realmContext) {
   }
 
   @Override
-  public synchronized Map<String, 
PolarisMetaStoreManager.PrincipalSecretsResult> bootstrapRealms(
-      List<String> realms) {
+  public Map<String, PolarisMetaStoreManager.PrincipalSecretsResult> 
bootstrapRealms(
+      List<String> realms, Function<String, PrincipalSecretsGenerator> 
rootSecretsPerRealm) {

Review Comment:
   I've reworked the generator code a bit. Hope it's clearer wrt realms now.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to