dimas-b commented on code in PR #422:
URL: https://github.com/apache/polaris/pull/422#discussion_r1847648430
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManagerImpl.java:
##########
@@ -698,12 +703,14 @@ private void bootstrapPolarisService(
/** {@inheritDoc} */
@Override
- public @NotNull BaseResult bootstrapPolarisService(@NotNull
PolarisCallContext callCtx) {
+ public @NotNull BaseResult bootstrapPolarisService(
+ @NotNull PolarisCallContext callCtx, PrincipalSecretsGenerator
rootSecretsGenerator) {
Review Comment:
reworked to avoid modifying public interfaces.
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisTreeMapMetaStoreSessionImpl.java:
##########
@@ -448,13 +448,16 @@ public int lookupEntityGrantRecordsVersion(
/** {@inheritDoc} */
@Override
public @NotNull PolarisPrincipalSecrets generateNewPrincipalSecrets(
- @NotNull PolarisCallContext callCtx, @NotNull String principalName, long
principalId) {
+ @NotNull PolarisCallContext callCtx,
+ @NotNull String principalName,
+ long principalId,
+ PrincipalSecretsGenerator generator) {
Review Comment:
reworked to avoid modifying public interfaces.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
