eric-maynard commented on code in PR #422:
URL: https://github.com/apache/polaris/pull/422#discussion_r1849129601


##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerFactory.java:
##########
@@ -58,11 +60,17 @@ public abstract class 
LocalPolarisMetaStoreManagerFactory<StoreType>
   private static final Logger LOGGER =
       LoggerFactory.getLogger(LocalPolarisMetaStoreManagerFactory.class);
 
+  private final PrincipalSecretsGenerator.Realms secretsGenerator = 
bootstrap();

Review Comment:
   I think it's fine as it is now, maybe in the future if there are more 
implementations we can refine it further. Thanks for iterating on this!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to