Gerrit-K commented on code in PR #601:
URL: https://github.com/apache/polaris/pull/601#discussion_r1900905485
##########
helm/polaris/templates/job.yaml:
##########
@@ -77,6 +77,10 @@ spec:
imagePullPolicy: {{ tpl .Values.image.pullPolicy . }}
command: ["/app/bin/polaris-service"]
args: ["bootstrap", "/app/config/polaris-server.yml"]
+ {{- if .Values.extraEnv }}
+ env:
+ {{- tpl (toYaml .Values.extraEnv) . | nindent 12 }}
Review Comment:
I was having the same thought, but wanted to keep it simple for the first
draft. But no problem 👌
Though, I would argue that a more general distinction might be necessary if
more values like that will be duplicated at some point (e.g. with the
`securityContext` from https://github.com/apache/polaris/pull/602).
In this case, I would rather suggest something like:
```yaml
bootstrapJob:
securityContext: {}
extraEnv: {}
deployment:
securityContext: {}
extraEnv: {}
```
This, however, would be a backwards-incompatible change.
Do you have any preferences?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
