Gerrit-K commented on code in PR #601:
URL: https://github.com/apache/polaris/pull/601#discussion_r1900935493
##########
helm/polaris/templates/job.yaml:
##########
@@ -77,6 +77,10 @@ spec:
imagePullPolicy: {{ tpl .Values.image.pullPolicy . }}
command: ["/app/bin/polaris-service"]
args: ["bootstrap", "/app/config/polaris-server.yml"]
+ {{- if .Values.extraEnv }}
+ env:
+ {{- tpl (toYaml .Values.extraEnv) . | nindent 12 }}
Review Comment:
> That said, if you prefer, let's keep it simple for now, and later on if
you have time, you could open another PR to introduce the refactoring above.
Does that work for you?
Sure, no problem! I pushed the corresponding change and will adjust the
other MR accordingly once this one looks good 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
