MonkeyCanCode commented on code in PR #601:
URL: https://github.com/apache/polaris/pull/601#discussion_r1900938267
##########
helm/polaris/templates/job.yaml:
##########
@@ -77,6 +77,10 @@ spec:
imagePullPolicy: {{ tpl .Values.image.pullPolicy . }}
command: ["/app/bin/polaris-service"]
args: ["bootstrap", "/app/config/polaris-server.yml"]
+ {{- if .Values.extraEnv }}
+ env:
+ {{- tpl (toYaml .Values.extraEnv) . | nindent 12 }}
Review Comment:
Yes, those are disabled due to https://github.com/apache/polaris/pull/422
(disabled print on non in-memory setup) and the credential in backend is
hashed. This looks good to me. Also, can we update the test case to reflect
this change?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
