adutra commented on code in PR #626:
URL: https://github.com/apache/polaris/pull/626#discussion_r1941094785
##########
.github/workflows/helm.yml:
##########
@@ -79,7 +79,7 @@ jobs:
if: steps.list-changed.outputs.changed == 'true'
run: |
helm plugin install
https://github.com/helm-unittest/helm-unittest.git || true
- helm unittest helm/polaris
+ helm unittest helm/polaris 2> >(grep -v 'found symbolic link' >&2)
Review Comment:
#912 is merged! I removed the workaround.
##########
helm/polaris/README.md:
##########
@@ -45,41 +48,139 @@ A Helm chart for Polaris.
### Optional
-When using a custom `persistence.xml`, a Kubernetes Secret must be created for
`.persistenceConfigSecret`. Below is a sample command:
+When using a custom `persistence.xml`, a Kubernetes Secret must be created for
it. Below is a sample command:
```bash
kubectl create secret generic polaris-secret -n polaris
--from-file=persistence.xml
```
-### From local directory (for development purposes)
+### Running the unit tests
-From Polaris repo root:
+Helm unit tests do not require a Kubernetes cluster. To run the unit tests
from the Polaris repo
+root:
```bash
-$ helm install polaris helm/polaris --namespace polaris --create-namespace
+helm unittest helm/polaris 2> >(grep -v 'found symbolic link' >&2)
Review Comment:
Removed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
