gh-yzou commented on code in PR #626: URL: https://github.com/apache/polaris/pull/626#discussion_r1944011803
########## helm/polaris/ci/fixtures/storage.yaml: ########## @@ -0,0 +1,27 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +apiVersion: v1 +kind: Secret +metadata: + name: polaris-storage +type: Opaque +stringData: + access-key: "my-key" + secret-key: "my-secret" Review Comment: new line ########## helm/polaris/ci/fixtures/token-broker.yaml: ########## @@ -0,0 +1,59 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +apiVersion: v1 +kind: Secret +metadata: + name: polaris-token-broker +type: Opaque +stringData: + private.pem: |- + -----BEGIN PRIVATE KEY----- + MIIEvQIBADANBgkqhkiG9w0BAQEFAASCBKcwggSjAgEAAoIBAQDiae5jQnQ+Dt8Optpa4fLNuUfI Review Comment: where does the private key and public key coming from ? will we be able to generate it on fly? ########## helm/polaris/ci/fixtures/persistence.yaml: ########## @@ -38,13 +38,17 @@ stringData: <class>org.apache.polaris.jpa.models.ModelSequenceId</class> <shared-cache-mode>NONE</shared-cache-mode> <properties> - <property name="jakarta.persistence.jdbc.url" value="jdbc:h2:mem:polaris-{realm}"/> - <property name="jakarta.persistence.jdbc.user" value="sa"/> - <property name="jakarta.persistence.jdbc.password" value=""/> + <property name="jakarta.persistence.jdbc.url" + value="jdbc:postgresql://postgres:5432/{realm}"/> + <property name="jakarta.persistence.jdbc.user" value="postgres"/> + <property name="jakarta.persistence.jdbc.password" value="postgres"/> <property name="jakarta.persistence.schema-generation.database.action" value="create"/> <property name="eclipselink.logging.level.sql" value="FINE"/> <property name="eclipselink.logging.parameters" value="true"/> <property name="eclipselink.persistence-context.flush-mode" value="auto"/> + <property name="eclipselink.connection-pool.default.initial" value="1" /> Review Comment: does that mean by default we will have a connection pool with size 1? maybe we should mention this in the read me, and along with some instruction about how to adjust the size ########## helm/polaris/ci/extra-service-values.yaml: ########## @@ -0,0 +1,47 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +image: + pullPolicy: Never + +service: + type: ClusterIP + sessionAffinity: ClientIP + internalTrafficPolicy: Cluster + externalTrafficPolicy: Cluster + ports: + - name: polaris-http Review Comment: is that two ports one for icebergRestCatalog service, and another one for OAuth service? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
