adutra commented on code in PR #626:
URL: https://github.com/apache/polaris/pull/626#discussion_r1944583098


##########
helm/polaris/ci/extra-service-values.yaml:
##########
@@ -0,0 +1,47 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+#
+
+image:
+  pullPolicy: Never
+
+service:
+  type: ClusterIP
+  sessionAffinity: ClientIP
+  internalTrafficPolicy: Cluster
+  externalTrafficPolicy: Cluster
+  ports:
+    - name: polaris-http

Review Comment:
   This file is just for tests and contains "bogus" data that does not 
necessarily reflect how `extraServices` will be used in real life, because in 
these tests we cannot create load balancers, ingresses, etc. 
   
   The typical use case for `extraServices` is:
   
   - User wants port 8181 to be exposed to internal clients (in the same 
namespace) using a `ClusterIP` service.
   - User also wants to expose port 8181 using a `LoadBalancer` service, for 
consumption by external clients (potentially with TLS termination, etc.)
   
   This can be achieved as follows:
   
   ```yaml
   service:
     type: ClusterIP
     ports:
       - name: polaris-http
         port: 8181
   
   extraServices:
     - nameSuffix: "ext"
       type: LoadBalancer
       ports:
       - name: polaris-http
         port: 8181
   ```
   
   Assuming the release name is `my-release`, the above will generate the 
following services:
   
   * `my-release` of type ClusterIP for port 8181;
   * `my-release-ext` of type LoadBalancer for port 8181;
   * it will also generate a `my-release-mgmt` service of type ClusterIP 
(headless) for port 8182.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to