HonahX commented on code in PR #936: URL: https://github.com/apache/polaris/pull/936#discussion_r1941839179
########## spec/polaris-catalog-apis/oauth-tokens-api.yaml: ########## @@ -0,0 +1,99 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# + +--- +paths: + # The /v1/oauth/tokens endpoint is sourced from rest-catalog-open-api.yaml Review Comment: IMHO, the goal here is to extract content outside of IRC to remove the dependency on rest-catalog-open-api.yaml (specifically for v1/oauth/tokens). This gives Polaris the flexibility to update or remove the deprecated version anytime, especially when upgrading IRC to a future release where the token endpoint is removed. I'm +1 on copying the content and adding the `CODE_COPIED_TO_POLARIS` header. WDYT? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
