dimas-b commented on code in PR #936: URL: https://github.com/apache/polaris/pull/936#discussion_r1947331636
########## LICENSE: ########## @@ -215,7 +215,10 @@ License: https://www.apache.org/licenses/LICENSE-2.0 This product includes code from Apache Iceberg. -* spec/rest-catalog-open-api.yaml +* spec/iceberg-rest-catalog-open-api.yaml +* spec/polaris-catalog-service.yaml Review Comment: no, this is Polaris' own file, it is NOT from Apache Iceberg, right? ########## spec/generated/bundled-polaris-catalog-service.yaml: ########## @@ -14,6 +14,9 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. + +# CODE_COPIED_TO_POLARIS Review Comment: This is generate file, it is certainly not copied from other repos. ########## LICENSE: ########## @@ -215,7 +215,10 @@ License: https://www.apache.org/licenses/LICENSE-2.0 This product includes code from Apache Iceberg. -* spec/rest-catalog-open-api.yaml +* spec/iceberg-rest-catalog-open-api.yaml +* spec/polaris-catalog-service.yaml +* spec/polaris-catalog-apis/oauth-tokens-api.yaml +* spec/generated/bundled-polaris-catalog-service.yaml Review Comment: generated files cannot possibly be copied from Iceberg. ########## spec/polaris-catalog-service.yaml: ########## @@ -17,6 +17,8 @@ # under the License. # +# CODE_COPIED_TO_POLARIS Review Comment: Is this file really copied from Iceberg? It looks like a genuine Polaris source file to me :thinking: -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
