HonahX commented on code in PR #936: URL: https://github.com/apache/polaris/pull/936#discussion_r1947343818
########## LICENSE: ########## @@ -215,7 +215,10 @@ License: https://www.apache.org/licenses/LICENSE-2.0 This product includes code from Apache Iceberg. -* spec/rest-catalog-open-api.yaml +* spec/iceberg-rest-catalog-open-api.yaml +* spec/polaris-catalog-service.yaml Review Comment: Thanks for all the great catch here! It seems I have misunderstood the intended use of the CODE_COPIED_TO_POLARIS flag and the corresponding licensing requirements. My current understanding is that this flag should only be applied to files where all content is copied from another project. Could you please confirm if that’s correct? Based on this understanding, here’s the current status: - `iceberg-rest-catalog-open-api.yaml`: identical to upstream released spec. **_Need_** `CODE_COPIED_TO_POLARIS` - `polaris-catalog-apis/oauth-tokens-api.yaml`: everything is copied from IRC spec's token endpoint definition. **_Need_** `CODE_COPIED_TO_POLARIS` - `polaris-catalog-service.yaml` - only the server and security definition are copied from IRC spec, while the rest are not. **_Do Not Need_** `CODE_COPIED_TO_POLARIS` - `bundled-polaris-catalog-service.yaml` - generated yaml that contains both IRC spec and polaris defined ones. _**Do Not Need**_ `CODE_COPIED_TO_POLARIS` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
