eric-maynard commented on code in PR #461:
URL: https://github.com/apache/polaris/pull/461#discussion_r1964867562
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/bootstrap/RootCredentialsSet.java:
##########
@@ -74,6 +76,54 @@ static RootCredentialsSet fromString(@Nullable String
credentialsString) {
: EMPTY;
}
+ /**
+ * Parse a JSON object of credentials. Example: { "realm1": { "client-id":
"client1",
+ * "client-secret": "secret1" }, "realm2": { "client-id": "client2",
"client-secret": "secret2",
+ * "extra-field": "extra-value" } }
Review Comment:
Agreed, but I wanted to showcase the behavior around `principal` that was
discussed above; it's not clear to me how to add that logic into `fromUrl`. If
there's an easy way, happy to just make that change now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
