eric-maynard commented on code in PR #461:
URL: https://github.com/apache/polaris/pull/461#discussion_r1976062296
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/bootstrap/RootCredentialsSet.java:
##########
@@ -74,6 +76,54 @@ static RootCredentialsSet fromString(@Nullable String
credentialsString) {
: EMPTY;
}
+ /**
+ * Parse a JSON object of credentials. Example: { "realm1": { "client-id":
"client1",
+ * "client-secret": "secret1" }, "realm2": { "client-id": "client2",
"client-secret": "secret2",
+ * "extra-field": "extra-value" } }
Review Comment:
While I agree that a shared method would be ideal, I don't see how we can
keep this principal-check logic in `fromJson` but remove it from `fromUrl`
while sharing a meaningful amount of code across the two methods. If it's okay
with you though, I'm happy just to push this logic down into `fromUrl` and then
share the code that way.
Otherwise, we can also remove this check altogether if you think it
shouldn't be there, or we can keep the divergent parsing logic. I don't have a
strong opinion here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
