dimas-b commented on code in PR #461:
URL: https://github.com/apache/polaris/pull/461#discussion_r1968252193
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/bootstrap/RootCredentialsSet.java:
##########
@@ -74,6 +76,54 @@ static RootCredentialsSet fromString(@Nullable String
credentialsString) {
: EMPTY;
}
+ /**
+ * Parse a JSON object of credentials. Example: { "realm1": { "client-id":
"client1",
+ * "client-secret": "secret1" }, "realm2": { "client-id": "client2",
"client-secret": "secret2",
+ * "extra-field": "extra-value" } }
Review Comment:
How about extracting a `private` shared method from `fromUrl` that would
take a `JsonFactory` and an `InputStream`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
