dimas-b commented on code in PR #1112:
URL: https://github.com/apache/polaris/pull/1112#discussion_r1981752140
##########
polaris-core/src/main/java/org/apache/polaris/core/persistence/PolarisMetaStoreManager.java:
##########
@@ -285,7 +285,11 @@ DropEntityResult dropEntityIfExists(
* @param entityId the id of the entity to load
*/
@Nonnull
- EntityResult loadEntity(@Nonnull PolarisCallContext callCtx, long
entityCatalogId, long entityId);
+ EntityResult loadEntity(
+ @Nonnull PolarisCallContext callCtx,
+ long entityCatalogId,
+ long entityId,
+ @Nonnull PolarisEntityType entityType);
Review Comment:
In general, from my POV, it is perfectly fine for an API to have redundant
inputs. Those can be used for validation as well as for optimization.
As for validation, the current behaviour expectation is to "not find" the
object if the given type parameter does not match actual type in storage. I
will update javadoc about that if we agree on adding the new parameter.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
