dennishuo commented on PR #1112: URL: https://github.com/apache/polaris/pull/1112#issuecomment-2705367338
> This is a good start point. Thanks a lot for doing this, @dimas-b! I'd suggest we move one step forward by adding `typeCode` to all entity related methods in the class `PolarisMetastoreManager`. By doing so, it literally enables a backend with separated tables/slices for different types of entities, which would benefit RDMS implementation(e.g., Postgres) a lot! > > More specifically, the following methodsn in the `PolarisMetastoreManager`: > > 1. `createEntityIfNotExists()` > 2. `createEntitiesIfNotExist()` > 3. `updateEntityPropertiesIfNotChanged()` > 4. `updateEntitiesPropertiesIfNotChanged()` > 5. `renameEntity()` > 6. `dropEntityIfExists()` > > Edit: We actually don't need to provide `typeCode` as the entity has it already. Thanks @singhpk234 for pointing out. I assume it is a mandatory field. Can anyone confirm? > > cc @singhpk234 @dennishuo @eric-maynard @jbonofre Correct, typeCode is currently mandatory on each entity. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
