sfc-gh-prsingh commented on code in PR #1112:
URL: https://github.com/apache/polaris/pull/1112#discussion_r1982123673
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java:
##########
@@ -351,7 +351,7 @@ public void deleteAll(@Nonnull PolarisCallContext callCtx) {
/** {@inheritDoc} */
@Override
public @Nullable PolarisBaseEntity lookupEntity(
- @Nonnull PolarisCallContext callCtx, long catalogId, long entityId) {
+ @Nonnull PolarisCallContext callCtx, long catalogId, long entityId, int
typeCode) {
Review Comment:
I see, thats fair, looking forward to the data model ! on how this is being
used.
##########
extension/persistence/eclipselink/src/main/java/org/apache/polaris/extension/persistence/impl/eclipselink/PolarisEclipseLinkMetaStoreSessionImpl.java:
##########
@@ -351,7 +351,7 @@ public void deleteAll(@Nonnull PolarisCallContext callCtx) {
/** {@inheritDoc} */
@Override
public @Nullable PolarisBaseEntity lookupEntity(
- @Nonnull PolarisCallContext callCtx, long catalogId, long entityId) {
+ @Nonnull PolarisCallContext callCtx, long catalogId, long entityId, int
typeCode) {
Review Comment:
I see, thats fair, looking forward to the data model ! on how this is being
used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
