eric-maynard commented on code in PR #1037:
URL: https://github.com/apache/polaris/pull/1037#discussion_r2013375330
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -303,9 +307,16 @@ public Response createTable(
.build();
}
} else if (delegationModes.isEmpty()) {
- return Response.ok(catalog.createTableDirect(ns,
createTableRequest)).build();
+ ETaggedResponse<LoadTableResponse> createResult =
+ catalog.createTableDirect(ns, createTableRequest);
+ return Response.ok(createResult.response())
+ .header(HttpHeaders.ETAG, createResult.eTag())
+ .build();
Review Comment:
I wonder if we even need `ETaggedReponse` now; we can pretty easily just
hash the location from the `LoadTableResponse` right?
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -303,9 +307,16 @@ public Response createTable(
.build();
}
} else if (delegationModes.isEmpty()) {
- return Response.ok(catalog.createTableDirect(ns,
createTableRequest)).build();
+ ETaggedResponse<LoadTableResponse> createResult =
+ catalog.createTableDirect(ns, createTableRequest);
+ return Response.ok(createResult.response())
+ .header(HttpHeaders.ETAG, createResult.eTag())
+ .build();
Review Comment:
I wonder if we even need `ETaggedResponse` now; we can pretty easily just
hash the location from the `LoadTableResponse` right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
