sfc-gh-mansingh commented on code in PR #1037:
URL: https://github.com/apache/polaris/pull/1037#discussion_r2014799276


##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -303,9 +307,16 @@ public Response createTable(
                   .build();
             }
           } else if (delegationModes.isEmpty()) {
-            return Response.ok(catalog.createTableDirect(ns, 
createTableRequest)).build();
+            ETaggedResponse<LoadTableResponse> createResult =
+                catalog.createTableDirect(ns, createTableRequest);
+            return Response.ok(createResult.response())
+                .header(HttpHeaders.ETAG, createResult.eTag())
+                .build();

Review Comment:
   I have removed `ETaggedResponse`, now we just generate it using the response 
at the `IcebergCatalogAdapter` level



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to