dimas-b commented on code in PR #1228:
URL: https://github.com/apache/polaris/pull/1228#discussion_r2017611056
##########
service/common/src/main/java/org/apache/polaris/service/persistence/InMemoryPolarisMetaStoreManagerFactory.java:
##########
@@ -59,8 +58,9 @@ public InMemoryPolarisMetaStoreManagerFactory(
this.storageIntegration = storageIntegration;
}
- public void onStartup(RealmContextConfiguration realmContextConfiguration) {
- bootstrapRealmsAndPrintCredentials(realmContextConfiguration.realms());
+ @Override
+ public void initializeForService(@Nonnull List<String> realmIds, @Nonnull
String defaultRealmId) {
Review Comment:
It looks like `defaultRealmId` is not used. Why have it as a parameter?
Also, why not call `bootstrapRealms` from `QuarkusProducers`? In the latter
case, it should be possible to inject root credentials from Quarkus config
(short term) or secret providers (long term). WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
