dimas-b commented on code in PR #1228:
URL: https://github.com/apache/polaris/pull/1228#discussion_r2017619819
##########
service/common/src/main/java/org/apache/polaris/service/persistence/InMemoryPolarisMetaStoreManagerFactory.java:
##########
@@ -59,8 +58,9 @@ public InMemoryPolarisMetaStoreManagerFactory(
this.storageIntegration = storageIntegration;
}
- public void onStartup(RealmContextConfiguration realmContextConfiguration) {
- bootstrapRealmsAndPrintCredentials(realmContextConfiguration.realms());
+ @Override
+ public void initializeForService(@Nonnull List<String> realmIds, @Nonnull
String defaultRealmId) {
Review Comment:
Re: `instanceof` checks, `QuarkusProducers` could rely on the persistence
type config for auto-bootstrapping instead.
That said, I would not mind the ability to auto-bootstrap (via a config
flag) when running with a real database to :) (can be deferred of course).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
