dimas-b commented on code in PR #1228:
URL: https://github.com/apache/polaris/pull/1228#discussion_r2019675123
##########
service/common/src/main/java/org/apache/polaris/service/persistence/InMemoryPolarisMetaStoreManagerFactory.java:
##########
@@ -59,8 +58,9 @@ public InMemoryPolarisMetaStoreManagerFactory(
this.storageIntegration = storageIntegration;
}
- public void onStartup(RealmContextConfiguration realmContextConfiguration) {
- bootstrapRealmsAndPrintCredentials(realmContextConfiguration.realms());
+ @Override
+ public void initializeForService(@Nonnull List<String> realmIds, @Nonnull
String defaultRealmId) {
Review Comment:
From my POV, if we have to add a public API method just to get rid of a type
check in "producers", I'd rather not change interfaces, but make produces call
the existing `bootstrapRealms` method.
We could have a config like `polaris.persistence.auto-bootstrap.type` with
default `in-memory` instead of type checks... WDYT?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
