dimas-b commented on code in PR #1284:
URL: https://github.com/apache/polaris/pull/1284#discussion_r2022896891
##########
polaris-core/src/main/resources/schemas/policies/system/snapshot-expiry/2025-02-03.json:
##########
@@ -1,8 +1,8 @@
{
"license": "Licensed under the Apache License, Version 2.0
(http://www.apache.org/licenses/LICENSE-2.0)",
- "$id":
"https://polaris.apache.org/schemas/policies/system/snapshot-retention/2025-02-03.json";,
- "title": "Snapshot Retention Policy",
- "description": "Inheritable Polaris policy schema for Iceberg table snapshot
retention",
+ "$id":
"https://polaris.apache.org/schemas/policies/system/snapshot-expiry/2025-02-03.json";,
+ "title": "Snapshot Expiry Policy",
+ "description": "Inheritable Polaris policy schema for Iceberg table snapshot
expiry",
Review Comment:
As for me, given the example below, the term "retention" looks more
relevant. Expiry means something is not valid/usable anymore, while the purpose
of this policy (although unstated) appears to be controlling when snapshots are
discarded, while still being logically valid.
(edit: removed "minor", let's discuss)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
