flyrain commented on code in PR #1284:
URL: https://github.com/apache/polaris/pull/1284#discussion_r2023528479
##########
polaris-core/src/main/resources/schemas/policies/system/snapshot-expiry/2025-02-03.json:
##########
@@ -1,8 +1,8 @@
{
"license": "Licensed under the Apache License, Version 2.0
(http://www.apache.org/licenses/LICENSE-2.0)",
- "$id":
"https://polaris.apache.org/schemas/policies/system/snapshot-retention/2025-02-03.json";,
- "title": "Snapshot Retention Policy",
- "description": "Inheritable Polaris policy schema for Iceberg table snapshot
retention",
+ "$id":
"https://polaris.apache.org/schemas/policies/system/snapshot-expiry/2025-02-03.json";,
+ "title": "Snapshot Expiry Policy",
+ "description": "Inheritable Polaris policy schema for Iceberg table snapshot
expiry",
Review Comment:
The example below demonstrates a free-form config map—its key-value pairs
can be anything, like `expire-in-days`. So we shouldn't base a strong argument
on this example alone. Using retention here isn't technically wrong, it's a
valid term. However, the main reason for renaming it to expiry is to make the
intent of this table maintenance policy more precise: it's specifically about
removing expired snapshots. Retention is a broader concept and could imply that
the maintenance job does more than just snapshot cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
