dimas-b commented on code in PR #1284:
URL: https://github.com/apache/polaris/pull/1284#discussion_r2023525362
##########
polaris-core/src/main/resources/schemas/policies/system/snapshot-expiry/2025-02-03.json:
##########
@@ -1,8 +1,8 @@
{
"license": "Licensed under the Apache License, Version 2.0
(http://www.apache.org/licenses/LICENSE-2.0)",
- "$id":
"https://polaris.apache.org/schemas/policies/system/snapshot-retention/2025-02-03.json";,
- "title": "Snapshot Retention Policy",
- "description": "Inheritable Polaris policy schema for Iceberg table snapshot
retention",
+ "$id":
"https://polaris.apache.org/schemas/policies/system/snapshot-expiry/2025-02-03.json";,
+ "title": "Snapshot Expiry Policy",
+ "description": "Inheritable Polaris policy schema for Iceberg table snapshot
expiry",
Review Comment:
Is the behaviour of this policy defined somewhere? (sorry, I'm missing the
obvious). It would help a lot in reasoning about names and descriptions... TBH,
the current description is rather obscure (also properties is just a bag of
arbitrary entries).
##########
polaris-core/src/main/resources/schemas/policies/system/snapshot-expiry/2025-02-03.json:
##########
@@ -1,8 +1,8 @@
{
"license": "Licensed under the Apache License, Version 2.0
(http://www.apache.org/licenses/LICENSE-2.0)",
- "$id":
"https://polaris.apache.org/schemas/policies/system/snapshot-retention/2025-02-03.json";,
- "title": "Snapshot Retention Policy",
- "description": "Inheritable Polaris policy schema for Iceberg table snapshot
retention",
+ "$id":
"https://polaris.apache.org/schemas/policies/system/snapshot-expiry/2025-02-03.json";,
+ "title": "Snapshot Expiry Policy",
+ "description": "Inheritable Polaris policy schema for Iceberg table snapshot
expiry",
Review Comment:
Is the behaviour of this policy defined somewhere? (sorry, if I'm missing
the obvious). It would help a lot in reasoning about names and descriptions...
TBH, the current description is rather obscure (also properties is just a bag
of arbitrary entries).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
