wolflex888 commented on code in PR #1164:
URL: https://github.com/apache/polaris/pull/1164#discussion_r2038379187
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java:
##########
@@ -853,6 +854,19 @@ public Map<String, String> getCredentialConfig(
storageInfo.get());
}
+ @Override
+ public Map<String, String> getVendedCredentialConfig(TableIdentifier
tableIdentifier) {
+ Map<String, String> vendedCredentialConfig = new HashMap<>();
+ String credentialsEndpoint =
+ String.format(
+ "/v1/%s/namespaces/%s/tables/%s/credentials",
Review Comment:
I moved the string construction to `IcebergCatalogAdapter` where the
decoding code exists, but I feel that's a little bit clumsy to pass it all the
way down to `SupportsCredentialDelegation`. I wonder if you have a more elegant
way of doing this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
