dimas-b commented on code in PR #1164:
URL: https://github.com/apache/polaris/pull/1164#discussion_r2042646772
##########
service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##########
@@ -392,15 +393,20 @@ public Response loadTable(
catalog -> {
LoadTableResponse response;
+
if (delegationModes.isEmpty()) {
response =
catalog
.loadTableIfStale(tableIdentifier, ifNoneMatch, snapshots)
.orElseThrow(() -> new
WebApplicationException(Response.Status.NOT_MODIFIED));
} else {
+ String credentialsEndpoint =
+ String.format(
+ "/v1/%s/namespaces/%s/tables/%s/credentials",
+ prefix, tableIdentifier.namespace().toString(),
tableIdentifier.name());
Review Comment:
`prefix` identifies the catalog, does it not? Why would the
`.../credentials` endpoint for a table in one catalog need to be under a
different prefix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
